🎨 [Frontend] Enh: Request services access #7924
Conversation
|
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
changed the title
odeimaiz
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
odeimaiz
added
t:enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR updates the “Request apps access” dialog to fetch owner/user information from the backend instead of relying on a cached group store.
- Replaces
osparc.store.Groupslookup with an asynchronousosparc.store.Users.getInstance().getUsercall. - Creates username and email labels up front and populates them once the backend responds (or sets an “unknown” fallback).
- Adds error handling for failed user lookups.
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js:61
- The variable
userGroupIdis misleading since it represents a user ID (the resource owner). Consider renaming it toownerIdoruserIdto improve clarity.
const userGroupId = cantReadServiceData["owner"];
services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js:89
- The new asynchronous branch should be covered by unit or integration tests (both success and failure paths) to prevent regressions in user lookup and UI updates.
osparc.store.Users.getInstance().getUser(userGroupId)
services/static-webserver/client/source/class/osparc/share/RequestServiceAccess.js
Show resolved
Hide resolved
|
@mergify queue |
🛑 The pull request could not be mergedThis could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 3 of 6 required status checks are expected.) |
|
This pull request has been removed from the queue for the following reason: Pull request #7924 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (details: 3 of 6 required status checks are expected.). You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. |
3 participants
What do these changes do?
This PR enhances the
Request apps accessdialog by asking the backend for the owners information instead of relying on the frontend's cache. This increases the chances to get the table properly populated.Related issue/s
How to test
Dev-ops